Allow passing custom HTTP headers #17219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglas-raillard-arm
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
douglas-raillard-arm
force-pushed
the
custom_http_headers
branch
from
eb95847
to
5036b23
Compare
|
PR updated with suggested rustfmt and clippy fixes |
douglas-raillard-arm
force-pushed
the
custom_http_headers
branch
from
5036b23
to
4e0bc01
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17219 +/- ##
==========================================
- Coverage 80.45% 80.42% -0.04%
==========================================
Files 1484 1484
Lines 195594 195634 +40
Branches 2778 2778
==========================================
- Hits 157368 157331 -37
- Misses 37714 37791 +77
Partials 512 512 ☔ View full report in Codecov by Sentry. |
|
PR updated with fixes for TOML lint |
douglas-raillard-arm
force-pushed
the
custom_http_headers
branch
from
4e0bc01
to
d69c404
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables passing custom HTTP headers to cloud functions, e.g.:
Fixes #17197
TODO: The ConfigKey system used to parse storage options does not seem to have support for a mapping value. For now, the code takes
<value>in'headers': <value>'and passes it as the value of a "Foobar" header as PoC. Any idea on how best to support an actualDict[HeaderName, HeaderValue]is welcome.